8000 Update install documentation to use re_path by mobilepattern · Pull Request #6613 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Update install documentation to use re_path #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Update install documentation to use re_path #6613

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59915d6
Update install documentation to use re_path
mobilepattern Feb 13, 2019
dc6afbf
Changed documentation to based on feedback from Bartosz Płóciennik
mobilepattern Mar 10, 2019
2a5bdd8
Merge branch 'develop' into patch-1
vthaian Mar 11, 2019
ccb4198
Merge branch 'develop' into patch-1
FinalAngel Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/how_to/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ Further required configuration
URLs
====

In the project's ``urls.py``, add ``url(r'^', include('cms.urls'))`` to the ``urlpatterns`` list. It should come after
In the project's ``urls.py``, add ``re_path(r'^', include('cms.urls'))`` to the ``urlpatterns`` list. It should come after
Copy link
@bplociennik bplociennik Mar 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request @mobilepattern.

Django 1.11 doesn't support re_path - it was introduced in Django 2.0.

We should keep documentation up to date with all supported Django versions (and have support for 1.11 as well). My suggestion is just to add an additional note about the new way of using URLs since Django 2.0+.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the change and added a note as suggested.

other patterns, so that specific URLs for other applications can be detected first.

You'll also need to have an import for ``django.conf.urls.include``. For example:
Expand Down
0