8000 Fixed #6585 -- Added missing clear cache for menu when page is created by bplociennik · Pull Request #6584 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Fixed #6585 -- Added missing clear cache for menu when page is created #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 14, 2019
Merged

Fixed #6585 -- Added missing clear cache for menu when page is created #6584

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e775593
Fixed missing clear cache for menu during save unpublished page
bplociennik Dec 19, 2018
6adbdfd
Moved clear_cache to AddPageForm
bplociennik Dec 20, 2018
8d08a0b
Add test for checking draft page is showing in menu
bplociennik Jan 3, 2019
316c6a1
Fix test
bplociennik Jan 3, 2019
adf5db6
Changed test
bplociennik Jan 4, 2019
2a7fc8e
Changed way of checking cache
bplociennik Jan 8, 2019
9f2fdd4
Add docstring for test
bplociennik Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed way of checking cache
  • Loading branch information
@bplociennik
bplociennik committed Jan 8, 2019
commit 2a7fc8e551ac0e85e783f4aba49ce885d87d5ad6
13 changes: 8 additions & 5 deletions cms/tests/test_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,25 +299,28 @@ def test_basic_cms_menu(self):

def test_show_new_draft_page_in_menu(self):
with self.login_user_context(self.get_superuser()):
response = self.client.post(URL_CMS_PAGE_ADD, self.get_new_page_data())
page_data_1 = self.get_new_page_data()
response = self.client.post(URL_CMS_PAGE_ADD, page_data_1)
self.assertRedirects(response, URL_CMS_PAGE)

request = self.get_request('/')
renderer = menu_pool.get_renderer(request)
renderer.draft_mode_active = True
renderer.get_nodes()
self.assertEqual(CacheKey.objects.first().key, 'cms_3.6.0rc1_menu_nodes_en_1:draft')
self.assertEqual(CacheKey.objects.count(), 1)

with self.login_user_context(self.get_superuser()):
page_data = self.get_new_page_data()
response = self.client.post(URL_CMS_PAGE_ADD, page_data)
page_data_2 = self.get_new_page_data()
self.assertNotEqual(page_data_1['slug'], page_data_2['slug'])
response = self.client.post(URL_CMS_PAGE_ADD, page_data_2)
self.assertRedirects(response, URL_CMS_PAGE)
page = Title.objects.drafts().get(slug=page_data['slug']).page
page = Title.objects.drafts().get(slug=page_data_2['slug']).page

request = self.get_request('/')
renderer = menu_pool.get_renderer(request)
renderer.draft_mode_active = True
nodes = renderer.get_nodes()
self.assertEqual(CacheKey.objects.count(), 1)
self.assertEqual(page.get_title(), nodes[-1].title)

def test_cms_menu_public_with_multiple_languages(self):
Expand Down
0