8000 Fixes/use svg icons by jrief · Pull Request #6455 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Fixes/use svg icons #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 36 commits into from
Closed

Fixes/use svg icons #6455

wants to merge 36 commits into from

Conversation

jrief
Copy link
Contributor
@jrief jrief commented Jul 23, 2018

Summary

Fixes #
If CMS_PERMISSION = True the inline admin of ALL PERMISSIONS renders icons. Since Django-1.9 these icons have been replaced by SVG variants, so use them.

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • [*] I have updated the release notes document if appropriate, with:
    • general notes
    • [*] bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

czpython and others added 30 commits April 16, 2018 10:34
@czpython
Added 3.6 CHANGELOG
163baaf
@czpython
Removed backwards compatible shims from 3.5
ed0c722
@czpython
Removed the cms moderator command
db8b1ef
@czpython
Dropped support for Django < 1.11
967b838
@czpython
Removed the translatable content get / set methods from CMSPlugin model
b1d1d50
@czpython
Removed signal handlers for Page, Title, Placeholder and CMSPlugin mo…
9988097 
…dels
@czpython
Updated links to contributing docs
0b930e5
@heppstux @czpython
Fixed django-cms#6340 -- Reorder models to support dumpdata (django-c… 8000
c5780a0 
…ms#6341)
@czpython
Fixed django-cms#6336 -- request.current_page should always respect d…
fe29ed6 
…raft/live state (django-cms#6350)
@chaosk @czpython
Refs django-cms#6185 -- Moved meta description length restriction fro…
dc1c19e 
…m model to form (django-cms#6362)

Increased meta description length restriction to 320 characters
@vxsx @czpython
Fixed django-cms#6353 -- Removed extra quotation mark from button sid…
6d2d14b 
…eframe template (django-cms#6364)
@vaquer @czpython
Fixed django-cms#6002 -- Prevent users from moving homepage under ano…
74ca478 
…ther page (django-cms#6369)
@Jamim @czpython
Updated links in README to use https where possible (django-cms#6375)
91b799e 
Fixed outdated links to documentation pages
@vxsx
Fixed a bug where structureboard tried to preload markup with legacy …
e9c1627 
…renderer
@vxsx
Fixed a bug with incorrect move plugin handling
61dfbdb
@evildmp
Fixed some spelling and build issues (django-cms#6391)
591efd6
@evildmp
Fixes/improves introductory tutorial (django-cms#6390)
32d9b73 
* introduces numbering of sections
* fixes django-cms#6359
@evildmp
Cleaned up apphooks documentation (django-cms#6397)
d5e25f4 
* fixes django-cms#6377

[ci only docs]
@evildmp
Improved toolbar tutorial (django-cms#6400)
4205eca 
* Improved toolbar tutorial
@evildmp
Docs tutorials small fixes (django-cms#6405)
9381429 
* Fixed typo
* Improved URLs explanation
@evildmp
Update 03-integrating_applications.rst
33bf57d
@evildmp
Docs tutorials small fixes (django-cms#6408)
25a6e11 
* Made minor improvements to tutorial
@czpython
Fixed django-cms#6346 -- Set xframe options exempt on cached response (…
675de13 
…django-cms#6403)
@czpython
Fixed django-cms#6335 -- Global permissions take precedence over cach…
899a3d8 
…ed page permissions (django-cms#6411)
@Chematronix @czpython
Update apphooks.rst (django-cms#6255)
0507212 
* Update apphooks.rst

You need to add *Application instance name* by hand to a page when you add an ``app_name`` #hopeitsavessomeoneelsethetrouble

* Changed as per czpython's suggestions

While still trying to convey that we're fixing the same problem than the previous paragraphs refers to (and that *Application instance name* only appears after setting ``app_name`` )
@sir-sigurd @czpython
Added page_title parameter to create_page API function(django-cms#6122)
deeccbc
@vxsx
Fixed a bug with not enabling plugins that are not rendered in content
a210eb7
@evildmp
Updated apphooks (how-to and introduction) (django-cms#6409)
09a8242 
* Updated apphooks how-to and introduction

[ci only docs]
@vxsx
Fixed a bug with expanding static placeholder by clicking on "Expand …
8964d77 
…All" button
@czpython
Introduced Django 2.0 & 2.1 support (django-cms#6402)
50dee52
@coveralls
Copy link
coveralls commented Jul 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.189% when pulling a998160 on jrief:fixes/use-svg-icons into 9d19af9 on divio:release/3.5.x.

czpython
czpython suggested changes Jul 24, 2018
View reviewed changes
Copy link
Contributor
@czpython czpython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrief
3.5 still supports 1.8
Can you push your changes to the develop branch?
Also please add an entry to CHANGELOG and remove the one from upgrade notes

@czpython czpython self-assigned this Jul 24, 2018
@czpython czpython added this to the 3.6.0 milestone Jul 24, 2018
jrief added 4 commits July 25, 2018 00:54
@jrief
Move release notes to changelog
fedae1c
@jrief
add compatibility layer for Django-1.8
b1eb9ab
@jrief
Merge branch 'develop' into fixes/use-svg-icons
28b7715 
# Conflicts:
#	CHANGELOG.txt
#	cms/appresolver.py
#	cms/tests/test_fixture_loading.py
#	cms/tests/test_permissions.py
#	docs/how_to/apphooks.rst
@jrief
describe change fix
a998160
@jrief jrief closed this Jul 24, 2018
@jrief jrief reopened this Jul 24, 2018
@jrief jrief closed this Jul 24, 2018
@jrief jrief mentioned this pull request Jul 25, 2018
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpython czpython czpython requested changes

Assignees

@czpython czpython

Labels
status: accepted
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
0