8000 Introduced app registration system by monikasulik · Pull Request #6421 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Introduced app registration system #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 26, 2018
Merged

Introduced app registration system #6421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4f4139e
App registry: autodiscover
monikasulik Jun 14, 2018
7db2fc9
App registration: Add cms_app attr to django app config
monikasulik Jun 14, 2018
0394871
App registration: run extension methods
monikasulik Jun 15, 2018
0ee728e
App registration: Some clean up
monikasulik Jun 15, 2018
f79f575
App registration: Edge cases
monikasulik Jun 15, 2018
f329f22
App registration: Configure CMS apps
monikasulik Jun 18, 2018
b5f1825
App registration: More clean up
monikasulik Jun 18, 2018
5b88aa1
Merge pull request #3 from monikasulik/app_registration_config
monikasulik Jun 19, 2018
c9f064d
App registration: Test comments
monikasulik Jun 19, 2018
e53eac3
App registration: Integrate into start up (WIP)
monikasulik Jun 21, 2018
f2299db
App registration: Clean up
monikasulik Jun 21, 2018
2416687
Merge pull request #4 from monikasulik/app_registration_start_up
monikasulik Jun 21, 2018
ec35c49
App registration: Remove import test (inconsistent across envs) and u…
monikasulik Jun 21, 2018
5968fc9
App registration: Clean up CMSAppConfig class
monikasulik Jun 21, 2018
c1b606e
Move app registration test apps to test_utils
monikasulik Jun 22, 2018
367e49f
App registration: CHANGELOG and AUTHORS changes
monikasulik Jun 22, 2018
31d767d
Merge pull request #5 from monikasulik/app_registration_improvements
monikasulik Jun 22, 2018
d908a66
App registration: Various minor changes after code review
monikasulik Jun 25, 2018
093408c
App registration: Split app config into 2 classes
monikasulik Jun 25, 2018
263c1c5
App registration: Polish up after separating config base classes
monikasulik Jun 25, 2018
741a803
Merge pull request #6 from monikasulik/app_registration_improvements
monikasulik Jun 25, 2018
bcc02f4
Fix python 2.7 compatibility issue
monikasulik Jun 26, 2018
e64a652
App registration: Improvements after code review
monikasulik Jun 26, 2018
6a55666
Clean up
monikasulik Jun 26, 2018
9f3f6f2
Clean up
monikasulik Jun 26, 2018
6e683d9
Fix abc import for python 2.7
monikasulik Jun 26, 2018
0850fd1
App registration: Clean up
monikasulik Jun 26, 2018
2055642
Minor cleanup
czpython Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
App registration: CHANGELOG and AUTHORS changes
  • Loading branch information
@monikasulik
monikasulik committed Jun 22, 2018
8000
commit 367e49fd745b5be59b072c72536e6744ea17d890
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ Contributors (based on gitlog, 497 unique authors):
* Milo Price
* Mitar
* Mokys
* Monika Sulik
* Morgan Wahl
* Motiejus Jakštys
* motleytech
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
=== 4.0.0 (unreleased) ===
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the PR guidelines suggest to do this but for 4.0.x, let's leave the changelog as is.
Once we're closer to release, then we can use the pr descriptions to compose the changelog.
The reason for this is that otherwise there will be conflicts all the time with changelog file and will need constant rebasing, etc..


* Added app registration system.


=== 3.6.0 (unreleased) ===

* Removed the ``cms moderator`` command.
Expand Down
1 change: 0 additions & 1 deletion cms/tests/test_app_registration.py
View file
Open in desktop
44C1
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import sys
from importlib import import_module
from mock import patch, Mock

Expand Down
0