Add a page changed flag for when fields on page are changed

django-cms · czpython · Jul 2, 2018 · Jun 15, 2018 · Jun 18, 2018 · Jun 18, 2018
commit 9bd9902ad5d16f06d712158113b9f16a27593b17
diff --git a/cms/admin/forms.py b/cms/admin/forms.py
@@ -26,7 +26,7 @@
 from cms.operations import (
     helpers as operation_helpers,
     ADD_PAGE_TRANSLATION,
-    CHANGE_PAGE_TRANSLATION,
+    CHANGE_PAGE,
 )
 from cms.plugin_pool import plugin_pool
 from cms.signals.apphook import set_restart_trigger
@@ -470,7 +470,7 @@ def save(self, commit=True):
 
         operation_token = operation_helpers.send_pre_page_operation(
             request=self.request,
-            operation=CHANGE_PAGE_TRANSLATION
+            operation=CHANGE_PAGE,
         )
 
         data = self.cleaned_data
@@ -500,7 +500,7 @@ def save(self, commit=True):
 
         operation_helpers.send_post_page_operation(
             request=self.request,
-            operation=CHANGE_PAGE_TRANSLATION,
+            operation=CHANGE_PAGE,
             token=operation_token,
             obj=cms_page,
         )

diff --git a/cms/operations/__init__.py b/cms/operations/__init__.py
@@ -13,6 +13,7 @@
 CLEAR_PLACEHOLDER = 'clear_placeholder'
 
 # Page operations
+CHANGE_PAGE = 'change_page'
 MOVE_PAGE = 'move_page'
 DELETE_PAGE = 'delete_page'
 

diff --git a/cms/signals/log_entries.py b/cms/signals/log_entries.py
@@ -10,6 +10,10 @@
         'message': _("Moved"),
         'flag': CHANGE,
     },
+    operations.CHANGE_PAGE: {
+        'message': _("Changed"),
+        'flag': CHANGE,
+    },
     operations.DELETE_PAGE: {
         'message': _("Deleted"),
         'flag': DELETION,

diff --git a/cms/tests/test_log_entries.py b/cms/tests/test_log_entries.py
@@ -110,9 +110,6 @@ def test_log_for_change_admin_page(self):
             LogEntry.objects.all().delete()
 
             # Get and edit the page
-            response = self.client.get(URL_CMS_PAGE_CHANGE % page.id)
-            self.assertEqual(response.status_code, 200)
-
             page_data['slug'] = 'changed slug'
             response = self.client.post(URL_CMS_PAGE_CHANGE % page.id, page_data)
             self.assertEqual(response.status_code, 302)
@@ -123,7 +120,7 @@ def test_log_for_change_admin_page(self):
             log_entry = LogEntry.objects.all()[0]
 
             # Check that the contents of the log message is correct
-            self.assertEqual('Changed Page Translation', log_entry.change_message)
+            self.assertEqual('Changed', log_entry.change_message)
 
             # Check the action flag is set correctly
             self.assertEqual(CHANGE, log_entry.action_flag)