8000 Fixed #6346 -- Set xframe options exempt on cached response by 0mk1 · Pull Request #6368 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Fixed #6346 -- Set xframe options exempt on cached response #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2018
Merged

Fixed #6346 -- Set xframe options exempt on cached response #6368

merged 4 commits into from
Jun 4, 2018

Conversation

0mk1
Copy link
@0mk1 0mk1 commented May 14, 2018 •
edited by czpython
Loading

Fixed #6346

@coveralls
Copy link
coveralls commented May 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.18% when pulling ecc9d0c on toffi9:issue-6346 into db4285d on divio:release/3.5.x.

@czpython czpython changed the title Fix issue 6346 Fixed #6346 -- Set xframe options exempt on cached response May 17, 2018
@czpython czpython self-assigned this May 17, 2018
@czpython czpython added this to the 3.5.3 milestone May 17, 2018
@vxsx vxsx requested a review from czpython May 28, 2018 12:35
chaosk
chaosk reviewed May 28, 2018
View reviewed changes
cms/tests/test_page.py 8000 Outdated
with self.settings(**override):
page = create_page('test page 1', 'nav_playground.html', 'en', published=True)

page.xframe_options = Page.X_FRAME_OPTIONS_ALLOW
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_page has an optional xframe_options argument

@czpython czpython merged commit 6f6e5e8 into django-cms:release/3.5.x Jun 4, 2018
@czpython
Copy link
Contributor
czpython commented Jun 4, 2018

Thanks!

This was referenced Jun 4, 2018
Merged
Merged
Closed
czpython added a commit that referenced this pull request Jun 5, 2018
@czpython
Fixed #6346 -- Set xframe options exempt on cached response (#6404)
8aed395 
Backport #6368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaosk chaosk chaosk left review comments

@czpython czpython Awaiting requested review from czpython

Assignees

@czpython czpython

Labels
needs to be backported Commits need to be backported needs to be forwardported status: accepted status: ready for review
Projects
None yet
Milestone
3.5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@0mk1 @coveralls @czpython @chaosk @vxsx
0