8000 Removed extra quotation mark from button sideframe template by vxsx · Pull Request #6365 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

Removed extra quotation mark from button sideframe template #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vxsx
Copy link
Contributor
@vxsx vxsx commented May 9, 2018

Backport of #6364
Fixes #6353

@vxsx vxsx requested a review from czpython May 9, 2018 12:08
@coveralls
Copy link
coveralls commented May 9, 2018

Coverage Status

Coverage remained the same at 77.757% when pulling 8dc5a95 on bugfix/remove-extra-quoteation-mark-from-button-sideframe-backport-3.5.x into 23d53b7 on release/3.5.x.

@czpython czpython added status: accepted backport Commits are being back ported labels May 9, 2018
@czpython czpython added this to the 3.5.3 milestone May 9, 2018
CHANGELOG.txt Outdated
@@ -5,6 +5,7 @@
* Fixed a bug where ``request.current_page`` would always be the public page,
regardless of the toolbar status (draft / live). This only affected custom
urls from an apphook.
* Removed extra quotation mark from the sideframe button tmeplate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tmeplate -> template

@vxsx vxsx merged commit bd1b4a2 into release/3.5.x May 28, 2018
@vxsx vxsx deleted the bugfix/remove-extra-quoteation-mark-from-button-sideframe-backport-3.5.x branch May 28, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Commits are being back ported status: accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0