8000 Fixed #5740 -- Use the correct url when ManifestStaticFilesStorage or similar is used by sephii · Pull Request #5964 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

Fixed #5740 -- Use the correct url when ManifestStaticFilesStorage or similar is used #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed #5740 -- Use the correct url when ManifestStaticFilesStorage or similar is used #5964

wants to merge 1 commit into from

Conversation

sephii
Copy link
@sephii sephii commented May 7, 2017

Fixed #5740.

@czpython czpython changed the title Fix static_with_version with ManifestStaticFilesStorage Fixed #5740 -- Use the correct url when ManifestStaticFilesStorage or similar is used May 7, 2017
@czpython czpython self-assigned this May 7, 2017
@czpython czpython added this to the 3.4.x milestone May 7, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.688% when pulling 4c2ff47 on sephii:5963-fix-static-files-manifest into 79e9d84 on divio:release/3.4.x.

@coveralls
Copy link
coveralls commented May 7, 2017

Coverage Status

Coverage remained the same at 82.688% when pulling 4c2ff47 on sephii:5963-fix-static-files-manifest into 79e9d84 on divio:release/3.4.x.

@ghost
Copy link
ghost commented May 9, 2017

Need to make sure #5907 isn't happening again.

@sephii
Copy link
Author
sephii commented May 10, 2017

Since this patch doesn't modify any attribute I don't think there's any risk but I can try to write a test for it.

yamadapc added a commit to beijaflor-io/django-cms that referenced this pull request May 29, 2017
…Storage or similar is used

Pulls django-cms#5964

sephii:5963-fix-static-files-manifest

4c2ff47
@czpython
Copy link
Contributor
czpython commented Jun 1, 2017

Hello @sephii,
Thanks for the patch.
Please provide a regression test for #5907

@sephii
Copy link
Author
sephii commented Sep 19, 2017

Closed in favour of #5993. Thanks @Pankrat !

@sephii sephii closed this Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0