Fixed #35667 -- Improved deprecation warning handling by replacing stacklevel with skip_file_prefixes #19887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from functools import partial | ||
|
|
||
| from django.core.exceptions import AppRegistryNotReady, ImproperlyConfigured | ||
| from django.utils.deprecation import django_file_prefixes |
There was a problem hiding this comment.
In #18683 (comment), @charettes suggested this shouldn't be dotted under .deprecation. (I held this feedback when landing #19823.) I think we should move it to django.utils.warnings...
There was a problem hiding this comment.
Thanks for pointing it out Jacob, I still think it shouldn't live under .deprecation as it is useful for non-deprecation warnings as well as demonstrated here.
| "Model '%s.%s' was already registered. Reloading models is not " | ||
| "advised as it can lead to inconsistencies, most notably with " | ||
| "related models." % (app_label, model_name), | ||
| RuntimeWarning, |
There was a problem hiding this comment.
... given this is not a deprecation use here.
adamchainz
reviewed
Sep 24, 2025
| filename, _, _, _ = stack[-4] | ||
| if not filename.startswith(os.path.dirname(django.__file__)): | ||
| warnings.warn(message, category, stacklevel=2) | ||
| warnings.warn(message, category, skip_file_prefixes=django_file_prefixes()) |
There was a problem hiding this comment.
I wondered what this function was for and realized it's no longer used, so I made a removal PR: #19901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35667
Branch description
Improved deprecation warning handling across Django by replacing stacklevel with skip_file_prefixes. This change ensures that deprecation warnings accurately point to the actual user code call sites by skipping Django's internal files, providing clearer and more actionable warning messages. The update leverages the django.utils.deprecation.django_file_prefixes() function to identify Django's internal files and implements consistent warning handling across the codebase including StreamingHttpResponse and AsyncPaginator.
Checklist
mainbranch.