Fixed #36389 -- Fixed GenericRelation.update() use write DB connection. #19476
Conversation
|
Whilst this fixes the case for |
Signed-off-by: SaJH <wogur981208@gmail.com>
|
Hi @RealOrangeOne, Thanks for the review! I felt that applying the suggested approach would lead to more unnecessary changes, so I decided to go with a slightly different solution instead. |
There was a problem hiding this comment.
Thank you @JaeHyuckSa
I also tested this against the test project in the ticket 👍
| queryset._defer_next_filter = True | ||
| return queryset.filter(**self.core_filters) |
There was a problem hiding this comment.
| queryset._defer_next_filter = True | |
| return queryset.filter(**self.core_filters) | |
| return queryset.filter(**self.core_filters) |
I think I can remove _defer_next_filter without test failures
However, this is almost identical to ManyRelatedManager._apply_rel_filters except this would then be:
| queryset._defer_next_filter = True | |
| return queryset.filter(**self.core_filters) | |
| queryset._defer_next_filter = True | |
| return queryset._next_is_sticky().filter(**self.core_filters) |
I am not sure what would be correct here but we can either simplify this or we should add more tests
Trac ticket number
ticket-36389
Branch description
Fixed GenericRelation.update() to use write database connection instead of read connection in multi-database environments.
Checklist
mainbranch.