8000 Clarified connection pool documentation. by ddelange · Pull Request #19442 · django/django · GitHub
[go: up one dir, main page]
Skip to content

Clarified connection pool documentation. #19442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarified connection pool documentation. #19442

wants to merge 1 commit into from
+20 −0

Conversation

ddelange
Copy link
@ddelange ddelange commented May 4, 2025 •
edited
Loading

Trac ticket number

Clarified the docs added in #17914.

Branch description

This branch is docs-only. I had to dig into the source to understand how this works. These added docs save future devs that effort.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label May 4, 2025
@ddelange ddelange marked this pull request as ready for review May 4, 2025 08:41
@ddelange ddelange mentioned this pull request May 4, 2025
Merged
github-actions[bot]
github-actions bot reviewed May 4, 2025
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@ddelange ddelange changed the title Clarified connection pool documentation Clarified connection pool documentation. May 4, 2025
@ddelange ddelange force-pushed the patch-1 branch 4 times, most recently from 0b1ff79 to 07d4bb1 Compare May 4, 2025 08:51
@ddelange ddelange mentioned this pull request May 4, 2025
Open
@ddelange
Copy link
Author
ddelange commented May 8, 2025 •
edited
Loading

Hi @felixxm 👋

Taking the liberty to ping you on this follow-up to your original PR :)

@ddelange
Copy link
Author

cc @timgraham 🙏

@felixxm
Copy link
Member
felixxm commented May 13, 2025

@ddelange Please stop pinging people. We will review it when we have some "free" time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelange @felixxm
0