Fixed #36255 -- Improved accessibility of the admin action button. #19300
Conversation
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
There was a problem hiding this comment.
Thank you for this @gtossou ⭐ this looks good
My only concern is this means a number of our admin documentation images will be outdated (see docs/intro/_images and docs/ref/contrib/admin/_images).
Could you take a look at updating these?
Note this process is manual and not documented (this ticket is around improving that ticket-35380)
Hello @sarahboyce thanks for the vigilance. Inded there are linked docs to update. I just made the changes. Can you please take a look? Thanks. It was pretty annoying to update them manually 😆 .I will take a look to the automatic generation ticket |
docs/intro/_images/admin13t.png
Outdated
There was a problem hiding this comment.
Can you make the width of this one slightly larger so there is no scrollbar added?
|
After #18958 has been merged, we need to rebase onto main and update the screenshots again. @Antoliny0919 I'm not sure if perhaps you can help with this? |
I was already thinking about it. 😏 |
docs/intro/_images/admin04t.png
Outdated
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @Antoliny0919 thanks for images. did you generated them with selenium ?
There was a problem hiding this comment.
No, I applied the code to the test environment and took the screenshot myself.
|
Hello! @gtossou It looks perfect to me! But there seems to be a conflict |
hmm... i thought a pull before would have resolved them |
Have you updated your forked repository to the latest version? You can update it first, then pull the changes and resolve the conflicts. 😏 |
…ecks. Regression in bf7b17d. Thanks Sage Abdullah for the report.
Regression in bf7b17d. Thanks Sage Abdullah for the report.
…y key is defined. This is to avoid confusion that a field is often associated with having a single associated database column.
The usage of time.sleep() could result in the update_or_create() thread winning the race to create the row if the backend takes a while to create a new connection in the main thread. Relying on threading.Event ensures that the flow of execution is systematically yield back and forth between the main thread and the thread in charge of performing the background update_or_create().
…) crash for non-string values. Regression in ca2be77.
…nstances. There is no need to call validate_ipv46_address() for ipaddress.IPv4Address()/ipaddress.IPv6Address() instances since this relies on trying to create these kind objects from strings, so they will always be valid.
…and renderers. Thank you Sarah Boyce, Carlton Gibson, Tim Schilling and Adam Johnson for reviews. Co-authored-by: Christophe Henry <contact@c-henry.fr> Co-authored-by: David Smith <smithdc@gmail.com> Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
…presentations. Ensured that rel_obj_attr and instance_attr return matching (pk, cls) tuples in GenericForeignKey.get_prefetch_queryset(), preventing mismatches when prefetching related objects where pk and get_prep_value() differ. Using value_to_string() also makes this code compatible with composite primary keys.
…id's Message. The `parse_header_parameters` function historically used Python's `cgi` module (now deprecated). In 34e2148, the logic was inlined to work around this deprecation ( #33173). Later, in d4d5427, the header parsing logic was further cleaned up to align with `multipartparser.py` (#33697). This change takes it a step further by replacing the copied `cgi` logic with Python's `email.message.Message` API for a more robust and maintainable header parsing implementation. Thanks to Raphael Gaschignard for testing, and to Adam Johnson and Shai Berger for reviews. Co-authored-by: Ben Cail <bcail@crossway.org> Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
docs.djangoproject.com had been updated to serve the object.inv file from the default location, so the second tuple element can be None (the "default" value).
…min. Visual regression in 857b104.
… when to model is invalid. Signed-off-by: saJaeHyukc <wogur981208@gmail.com>
…der in the admin on small screens. Visual regression in b1324a6.
Forwardport of cc31b38 from stable/5.2.x.
…related fields. With thanks to Konrad Świat, Loïc Bistuer, Russell Keith-Magee, and Mariusz Felisiak. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
…le guide (PEP-448).
…n navigation sidebar loading flicker." This reverts commit 747b417 that caused a visual regression when both navigation and filter sidebars are visible.
… properly.
In the admin, when selecting related objects via the helpers defined in
`RelatedObjectLookups.js`, the `dismissRelatedLookupPopup` function was
attempting to access `window.relatedWindows`, which does not exist in
real execution, causing related lookup popups to remain open.
This change ensures that this code correctly accesses the module-local
`relatedWindows` by explicitly assigning it to `window.relatedWindows`.
Regression in 91bebf1.
Thanks Matthias Kestenholz for the report, the fix ideas, and testing.
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
…ySet.update(). Co-authored-by: Andro Ranogajec <ranogaet@gmail.com>
…lid object_id for a UUIDField pk.
…st_and_scheme() on Windows. Thank you sw0rd1ight for the report.
…sforms and references. Regression in 65ad4ad. Refs #28900 Thanks Patrick Altman for the report.
Trac ticket number
ticket-36255
Branch description
Rename Django Admin's "Go" button and remove its title attribute
Old naming
New naming
Checklist
mainbranch.