8000 Refs #33247 -- Pinned Sphinx version for RTD builds. by carltongibson · Pull Request #15053 · django/django · GitHub
[go: up one dir, main page]
Skip to content

Refs #33247 -- Pinned Sphinx version for RTD builds. #15053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2021
Merged

Refs #33247 -- Pinned Sphinx version for RTD builds. #15053

merged 2 commits into from
Nov 3, 2021

Conversation

carltongibson
Copy link
Member

The default Sphinx version used by RTD is not compatible with Python 3.8+.
Specified a pinned recent version of Sphinx, in line with RTD docs.
https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html#pinning-dependencies

@carltongibson carltongibson requested a review from felixxm November 3, 2021 14:57
@carltongibson
Copy link
Member Author

This PR on crate/crate-docs is instructive for the various steps one might go through here 😄

crate/crate-docs#52

felixxm
felixxm reviewed Nov 3, 2021
View reviewed changes
@carltongibson
Refs #33247 -- Pinned Sphinx version for RTD builds.
42091f2 
The default Sphinx version used by RTD is not compatible with Python 3.8+.
Specified a pinned recent version of Sphinx, in line with RTD docs.
https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html#pinning-dependencies
@carltongibson
Refs #33247 -- Set Python 3.8 for RTD builds.
b43fdab 
Python 3.8 is compatible with all current versions of Django.

Thanks to Mariusz Felisiak for the suggestion.
@felixxm felixxm merged commit 447b6c8 into django:main Nov 3, 2021
@felixxm
Copy link
Member
felixxm commented Nov 3, 2021

@carltongibson Thanks 👍

@carltongibson
Copy link
Member Author

Thanks for backporting @felixxm. We're green on RTD now so 👍

jlaine pushed a commit to jlaine/django that referenced this pull request Dec 13, 2021
@blueyed @felixxm
Refs django#15053 -- Clarified debug message when skipping templates …
c70cd2a 
…to avoid recursion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carltongibson @felixxm
0