8000 Refs #32074 -- Removed usage of Python's deprecated distutils.version package. by felixxm · Pull Request #14240 · django/django · GitHub
[go: up one dir, main page]

Skip to content

Refs #32074 -- Removed usage of Python's deprecated distutils.version package. #14240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

felixxm
Copy link
Member
@felixxm felixxm commented Apr 9, 2021

The distutils package was formally deprecated in Python 3.10 and will be removed in Python 3.12.

See PEP 632 and distutils.version.LooseVersion.

… package.

The distutils package was formally deprecated in Python 3.10 and will
be removed in Python 3.12.
@felixxm felixxm requested a review from carltongibson April 9, 2021 07:58
Copy link
Member
@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks fine, and tests in tests/version/tests.py 👍
Thanks

@felixxm
Copy link
Member Author
felixxm commented Apr 9, 2021

@carltongibson Thanks for checking 👍

@felixxm felixxm merged commit b8c9e9f into django:main Apr 9, 2021
@felixxm felixxm deleted the distutils-depr branch April 9, 2021 10:56
ericsnowcurrently pushed a commit to python/pyperformance that referenced this pull request Nov 28, 2022
Fixes #247.

Django has a runtime dependency on distutils, so adding setuptools as a dependency resolves it.

This has already been resolved upstream [1], but this allows us to keep using the same version of Django for the benchmark.

[1] django/django#14240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0