8000 Fixed #32069 -- Fixed admin change-form layout on small screens. by carltongibson · Pull Request #13573 · django/django · GitHub
[go: up one dir, main page]
Skip to content

Fixed #32069 -- Fixed admin change-form layout on small screens. #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fixed #32069 -- Fixed admin change-form layout on small screens. #13573

merged 1 commit into from
Oct 21, 2020

Conversation

carltongibson
Copy link
Member
@carltongibson carltongibson commented Oct 20, 2020 •
edited
Loading

ticket-32069. Alternative to #13514.

This was present since the responsive admin was introduced in dc37e88.
Regression in 8ee4bb6, where it was accidentally removed. (That's the question.)

See diff — looking again, this change isn't related to ticket-31986 no?

Reverting that line restores the old behaviour, and I can't see a regression elsewhere.

@carltongibson carltongibson requested a review from felixxm October 20, 2020 07:56
@carltongibson
Copy link
Member Author

@knyghty Can I ask you to comment on this? Thanks! 😀
8000

knyghty
knyghty approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member
@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't see a reason for it, perhaps I inadvertently saved it from inside the dev tools or something.

@felixxm felixxm mentioned this pull request Oct 21, 2020
Closed
felixxm
felixxm reviewed Oct 21, 2020
View reviewed changes
Copy link
Member
@felixxm felixxm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carltongibson Thanks 👍

I found another regression in Django 3.1 with the admin changelist filter sidebar, when width is less than 887px then textarea is cut off:

obraz

Maybe we can fix it here 🤔 at least release notes will match 😄

Related CSS:

.colM .aligned .vLargeTextField, .colM .aligned .vXMLLargeTextField {
    width: 610px;
}

@carltongibson
Copy link
Member Author
carltongibson commented Oct 21, 2020 •
edited
Loading

Hey @felixxm — AFAICS 🤔 that behaviour is the same in 3.1.0, so not a regression in 3.1.1 ?

Maybe it's a bug in a new feature? (But it might just be Close the sidebar! — for which we call it a Cleanup? — I seem to recall we discussed that the sidebar was always going to need to be shut by users for these small-medium screens... 🤔)

Either way, we can look at it here but I'm not sure it's the same issue.

What do you think?

@felixxm
Copy link
Member
felixxm commented Oct 21, 2020

Hey @felixxm — AFAICS thinking that behaviour is the same in 3.1.0, so not a regression in 3.1.1 ?

Maybe it's a bug in a new feature? (But it might just be Close the sidebar! — for which we call it a Cleanup?)

Yes, it's a bug in a new feature.

Either way, we can look at it here but I'm not sure it's the same issue.

What do you think?

OK, I will create a new ticket. I shouldn't try to smuggle this 😉 🕶️

@carltongibson
Fixed #32069 -- Fixed admin change-form layout on small screens.
f12767a 
Restored flex-wrap CSS declaration to form elements at smallest breakpoint.
This was present since the responsive admin was introduced in dc37e88.
Regression in 8ee4bb6, where it was accidentally removed.
@carltongibson carltongibson changed the title Fixed #32069 -- Restored flex-wrap CSS declaration to form elements on small screens Fixed #32069 -- Fixed admin change-form layout on small screens. Oct 21, 2020
@carltongibson
Copy link
Member Author

@felixxm I adjusted the commit message ("what" not "how") and rebased.

felixxm
felixxm approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member
@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks👍

@carltongibson carltongibson merged commit 257f849 into django:master Oct 21, 2020
@carltongibson carltongibson deleted the c/32069-admin-forms-small branch October 21, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm approved these changes

@knyghty knyghty knyghty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carltongibson @felixxm @knyghty
0