8000 Fixed #32107 -- Fixed ProtectedError.protected_objects and RestrictedError.restricted_objects. by hramezani · Pull Request #13560 · django/django · GitHub
[go: up one dir, main page]
Skip to content

Fixed #32107 -- Fixed ProtectedError.protected_objects and RestrictedError.restricted_objects. #13560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fixed #32107 -- Fixed ProtectedError.protected_objects and RestrictedError.restricted_objects. #13560

merged 1 commit into from
Oct 19, 2020

Conversation

hramezani
Copy link
Member

felixxm
felixxm reviewed Oct 19, 2020
View reviewed changes
@hramezani hramezani force-pushed the ticket_32107 branch 2 times, most recently from f3e6e6e to f72f14c Compare October 19, 2020 07:13
felixxm
felixxm reviewed Oct 19, 2020
View reviewed changes
Copy link
Member
@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani Thanks 👍 I think we should return set() instead of list(), as we did before 4ca5c56.

@felixxm felixxm changed the title Fixed #32107 -- Changed protected_objects/restricted_objects in ProtectedError/RestrictedError to list. Fixed #32107 -- Fixed ProtectedError.protected_objects and RestrictedError.restricted_objects. Oct 19, 2020
@felixxm
Copy link
Member
felixxm commented Oct 19, 2020

@hramezani Thanks 👍 I added release notes.

@hramezani @felixxm
Fixed #32107 -- Fixed ProtectedError.protected_objects and Restricted…
3b1746d 
…Error.restricted_objects.

Regression in 4ca5c56 and
ab3cbd8.

Thanks Vitaliy Yelnik for the report.
@felixxm felixxm merged commit 3b1746d into django:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hramezani @felixxm
0