UX: Display interpolation keys in site text and email template editors #37254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing site texts or email templates, admins can now see which
interpolation keys are available for that particular translation. Keys
that are already used in the content are highlighted in bold, making it
easy to see at a glance which placeholders are in use and which ones
are still available.
This also improves the server-side validation for interpolation keys.
Previously, malformed keys like `%{user.username}` would silently pass
validation because the regex only matched word characters. Now we use
a more permissive pattern that catches any `%{...}` attempt and properly
reports invalid keys, helping admins catch typos before saving.
Ref - t/172375
ZogStriP
commented
Jan 21, 2026
Comment on lines
+389
to
+393
| &:not(:last-of-type)::after { | ||
| content: " - "; | ||
| font-weight: normal; | ||
| color: var(--primary-low-mid); | ||
| } |
Member
Author
There was a problem hiding this comment.
I don't like this hack one bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing site texts or email templates, admins can now see which interpolation keys are available for that particular translation. Keys that are already used in the content are highlighted in bold, making it easy to see at a glance which placeholders are in use and which ones are still available.
This also improves the server-side validation for interpolation keys. Previously, malformed keys like
%{user.username}would silently pass validation because the regex only matched word characters. Now we use a more permissive pattern that catches any%{...}attempt and properly reports invalid keys, helping admins catch typos before saving.Ref - t/172375