Refactoring #207
Merged
Refactoring #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs a refactoring update to both the cryptography and cryptography_flutter packages, bumping their versions to 2.8.1 and 2.3.4 respectively.
- Simplified internal APIs by removing redundant wrapper functions (
base64UrlDecodeUnmodifiable*→base64UrlDecode*) - Added
@internalannotations to expose internal APIs for package-internal use - Fixed missing semicolons in documentation examples
- Removed empty file that only contained a license header
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cryptography_flutter/pubspec.yaml | Version bump to 2.3.4 and dependency update to cryptography ^2.8.1 |
| cryptography_flutter/lib/src/flutter/flutter_ecdh.dart | Code formatting improvement (line break for readability) |
| cryptography_flutter/lib/src/cryptography_unsupported_error.dart | Removed file containing only license header (no actual code) |
| cryptography_flutter/lib/src/_internal.dart | Added @internal annotations to helper functions |
| cryptography_flutter/lib/cryptography_flutter.dart | Removed export of deleted empty file |
| cryptography_flutter/README.md | Updated version references in documentation |
| cryptography_flutter/CHANGELOG.md | Added changelog entry for version 2.3.4 |
| cryptography/pubspec.yaml | Version bump to 2.8.1 |
| cryptography/lib/src/cryptography/algorithms.dart | Fixed missing semicolons in documentation code examples |
| cryptography/lib/src/browser/rsa_ssa_pkcs1v15.dart | Updated to use simplified base64UrlDecode functions |
| cryptography/lib/src/browser/rsa_pss.dart | Updated to use simplified base64UrlDecode functions and cleaned up imports |
| cryptography/lib/src/browser/browser_ec_key_pair.dart | Updated to use simplified base64UrlDecode functions |
| cryptography/lib/src/browser/_javascript_bindings.dart | Removed wrapper functions, reorganized extension types alphabetically, added @internal annotations |
| cryptography/README.md | Updated version references in documentation |
| cryptography/CHANGELOG.md | Added changelog entry for version 2.8.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
114bf57 to
7b190be
Compare
7b190be to
033f45d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.