8000 Allow for optionally extending the max time the pypi fetching repoctx action can last by thundergolfer · Pull Request #23 · dillon-giacoppo/rules_python_external · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 20, 2020. It is now read-only.

Allow for optionally extending the max time the pypi f 8000 etching repoctx action can last #23

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

thundergolfer
Copy link
Collaborator

Description

In the DS repo we're experiencing timeouts.

There's precedent for this here.

If we add the option to say that your requirements.txt is already transitively resolved we can do parallel fetching like https://github.com/ali5h/rules_pip does.

Copy link
Owner
@dillon-giacoppo dillon-giacoppo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love the idea of parallel downloads, would make all the builds significantly faster

@thundergolfer
Copy link
Collaborator Author

This works fine in test on DS repo. Will merge.

@thundergolfer thundergolfer merged commit 95e72ce into master Feb 27, 2020
@thundergolfer thundergolfer deleted the jonathon/pip-timeout-configurability branch February 27, 2020 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0