Open
Conversation
- Added `ref` prop to `BulkSelectionProps` for better ref management. - Refactored `ButtonElement` to remove `forwardRef` and handle refs directly. - Updated various components in the CICDHistory section to include `type JSX` imports for better type safety. - Improved ref initialization in `CodeEditor` and `CodeEditorRenderer` components. - Added global type definitions for JSX to maintain compatibility with third-party libraries. - Updated `index.ts` to enhance query and mutation metadata interfaces in react-query.
There was a problem hiding this comment.
Pull request overview
This PR upgrades the library from React 18 to React 19 and TanStack Query v4 to v5, along with several other dependency updates. The changes include refactoring components to remove forwardRef usage in favor of direct ref prop handling, adding JSX type imports for React 19 compatibility, and implementing a global JSX namespace shim to maintain compatibility with third-party libraries.
Changes:
- Upgraded React 18 → 19, TanStack Query v4 → v5, and several other dependencies (framer-motion, react-day-picker, etc.)
- Removed
forwardReffrom Button, BulkSelection, Checkbox, and RJSFForm components in favor of direct ref prop handling - Added global JSX namespace shim in
globals.d.tsto maintain compatibility with third-party libraries like react-select - Migrated TanStack Query type augmentation from QueryMeta/MutationMeta to Register interface pattern
- Updated
cacheTimetogcTimein TanStack Query configuration - Added
type JSXimports across multiple files for React 19 type compatibility - Enabled
navLayout="around"prop in DateTimePicker (previously commented out) - Initialized refs with
nullinstead ofundefinedin multiple components
Reviewed changes
Copilot reviewed 54 out of 56 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json & package-lock.json | Upgraded React to 19.2.4, TanStack Query to 5.90.21, framer-motion to 11.18.2, react-day-picker to 9.11.2, and other dependencies |
| src/globals.d.ts | New file adding JSX namespace shim for React 19 compatibility with third-party libraries |
| src/index.ts | Migrated TanStack Query type augmentation to use Register interface pattern |
| src/Shared/Components/Button/Button.component.tsx | Removed forwardRef, implemented direct ref handling with callback |
| src/Shared/Components/BulkSelection/BulkSelection.tsx | Removed forwardRef, added ref prop to interface |
| src/Common/Checkbox/Checkbox.tsx | Removed forwardRef, added ref prop handling |
| src/Common/RJSF/Form.tsx | Removed forwardRef, ref now passed directly to underlying Form component |
| src/Common/Types.ts | Replaced deprecated React.ReactChild with ReactElement | number | string union |
| src/Common/API/QueryClientProvider.tsx | Updated cacheTime to gcTime for TanStack Query v5 |
| src/Shared/Components/DatePicker/DateTimePicker.tsx | Enabled navLayout prop (previously commented out) |
| Multiple type files | Added type JSX imports for React 19 compatibility |
| Multiple component files | Initialized useRef hooks with null instead of undefined |
| CLAUDE.md | Added documentation file for Claude Code integration (new file) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ete unused illustration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refprop toBulkSelectionPropsfor better ref management.ButtonElementto removeforwardRefand handle refs directly.type JSXimports for better type safety.CodeEditorandCodeEditorRenderercomponents.index.tsto enhance query and mutation metadata interfaces in react-query.