[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: bash: Remove invisible outline of plain icon #2263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update icon: bash: Remove invisible outline of plain icon #2263

wants to merge 1 commit into from

Conversation

Finii
Copy link
@Finii Finii commented Sep 5, 2024

[why]
When calculating the bounding box of the icon the real icon is too far right. There is in fact a invisible box on the real icon's left.

[how]
Edit svg file directly (in vi) and just remove the outline's description.

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Load icon into inkscape and just select all - note the ghost square on the left ?!

image

Removed path marked blue:

image

This PR closes NONE

Notes

@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)

@Finii
bash: Remove invisible outline of plain icon
2515d79 
[why]
When calculating the bounding box of the icon the real icon is too far
right. There is in fact a invisible box on the real icon's left.

[how]
Edit `svg` file directly (in vi) and just remove the outline's
description.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii changed the title bash: Remove invisible outline of plain icon update icon: bash: Remove invisible outline of plain icon Sep 5, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team September 25, 2024 09:11
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Finii @Snailedlt