[Monorepo] init #609
[Monorepo] init #609
Conversation
|
@muglug Could I ask you for help with this? I have no idea how to disable it The interface is just semideprecated - method is missing so not usable yet |
|
Add |
|
Thank you |
|
Can I ignore just one file for specific rule? I'd like to keep it up for the rest of code |
|
To exclude a given file, you can do <SomeIssueName>
<errorLevel="info">
<file name="path/to/file.php" />
</errorLevel>
</SomeIssueName>You can also suppress in the file itself with |
|
@muglug Thank you, took a while to figure out typo, but I inspired in other ignored files in the file 👍 <InvalidArgument>
<errorLevel type="info">
<file name="packages/EasyCodingStandard/src/DependencyInjection/Extension/CheckersExtension.php" />
</errorLevel>
</InvalidArgument> |
|
@carusogabriel Could I ask you for review? @vitek-rostislav I'm merging this now, to prapare and test subsplit package, but review is still welcomed 👍 |
|
@carusogabriel Thanks |
| @@ -0,0 +1,3 @@ | |||
| parameters: | |||
| build: | |||
| 'git@github.com:shopsys/product-feed-zbozi.git': 'packages/ProductFeedZbozi' | |||
There was a problem hiding this comment.
Is it ok to use "live" repository instead of "testing one"? (eg. git@github.com:shopsys/product-feed-zbozi-copy.git)
There was a problem hiding this comment.
Yes, this is read only operation. Fetch only
| @@ -0,0 +1,46 @@ | |||
| # Monorepo - Build and Maintain Monorepo like a Boss | |||
There was a problem hiding this comment.
When reading the file, it is quite unclear to me, why I should create extra project for creating the desired monorepo
There was a problem hiding this comment.
I tried to rephrase and make the 2 directory issue more clear
|
|
||
| ## Usage | ||
|
|
||
| ### 3 Steps to Build Monolitic Repository from Many Repositories |
There was a problem hiding this comment.
The correct term is "Monolithic" :) it misspelled few times across the project
| 'git@github.com:shopsys/product-feed-heureka.git': 'packages/ProductFeedHeureka' | ||
| ``` | ||
|
|
||
| 2. Prepare empty directory where, do you want to create your monorepo, e.g. `new-monorepo`. It should be outside current working directory. |
There was a problem hiding this comment.
I think better formulation is "...empty directory where you want to create..." but I am not a native speaker :)
There was a problem hiding this comment.
Agreed. There was ", do" extra
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "Symplify\\Monoraper\\": "src" |
There was a problem hiding this comment.
should be Symplify\Monorepo\
There was a problem hiding this comment.
Fixed in following PR. Thanks
| * | ||
| * Empty directories will remain | ||
| */ | ||
| public function prependHistoryToNewPackageFiles( |
There was a problem hiding this comment.
again, the name of the method does not reflect its behaviour.
There was a problem hiding this comment.
How would you name it?
| { | ||
| public function mergeRepositoryToMonorepoDirectory(string $gitRepository, GitWorkingCopy $gitWorkingCopy): void | ||
| { | ||
| $remoteName = md5($gitRepository); |
There was a problem hiding this comment.
That's actually debug code, since naming remote the same way the repository failed in certain time in development.
Might not be needed anymore, I'll investigate
There was a problem hiding this comment.
Ok, it's still needed. So I've created a special method for that with clear name
| # author: https://github.com/emiller | ||
| # source: https://gist.github.com/emiller/6769886 | ||
|
|
||
| ## Todo |
There was a problem hiding this comment.
Does this mean that following 2 points are not implemented yet?
There was a problem hiding this comment.
This is outdated, will be removed in following PR
| # | ||
| # git-rewrite-history [-d/--dry-run] [-v/--verbose] <srcname>=<destname> <...> <...> | ||
| # | ||
| # After the repsitory is re-written, eyeball it, commit and push up. |
There was a problem hiding this comment.
typo, repsitory :)
| $containerBuilder, | ||
| Application::class, | ||
| Command::class, | ||
| 'add' |
There was a problem hiding this comment.
where this come from?
There was a problem hiding this comment.
This is method call to add commands. Basicall this does following:
$commands = $this->container->getAllByType(Command::class);
foreach ($commands as $command) {
$application->add($command);
}Here is README for the feature.
This aallows extendability over autoconfigure + !tagged approach, which is only local per config. See more in Symfony issue where I explain in more detail.
|
Follow up in #613 |
No description provided.