Stop using a node16 devcontainer image #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added because actions was still on node 16, but codespaces / devcontainers were running newer: * #334 * #337 However, Actions has now migrated to node 20: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ And we migrated this action here: * #443 So now we have the opposite problem, that our devcontainer is now outdated. I considered updating it, but we'd prefer not to manage these versions unless we have to... as it's just one more thing to maintain on a repo that doesn't see a lot of activity. So instead I removed it and we'll just inherit the default for now. If we later need a custom one, it's easy to re-add.
rickreyhsig
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added because actions was still on node 16, but codespaces / devcontainers were running newer:
.devcontainer#334However, Actions has now migrated to node 20:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
And we migrated this action here:
So now we have the opposite problem, that our devcontainer is now outdated.
I considered updating it, but we'd prefer not to manage these versions unless we have to... as it's just one more thing to maintain on a repo that doesn't see a lot of activity.
So instead I removed it and we'll just inherit the default for now. If we later need a custom one, it's easy to re-add.