feat: support Deno v1.25 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are not backward compatible with Deno version 1.24 and below!
Deno 1.25 released with some changes to the FFI API.
bufferpointerno longer accept JavaScriptTypedArray. Instead, we need to use typebuffer.Deno.PointerValueDeno now returns pointers as
numberorbigintaccording to their size. See Deno CLI API.This means that all pointers
0nwill now be0.Misc
Deno FFI functions now accept
numberas a pointer (altough their TypeScript type definitions still says they only supportbigint)These changes broke deno_python, so I fixed the code to support the latest version of Deno.
All tests should now pass on Deno 1.25.
I've been out of the loop for a while, so let me know if I missed anything 😄