This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(k8s.py): access API server by IP address #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
And I guess the k8s API can't be accessed by plain old http, eh? I haven't seen a way, so makes sense to me to disable SSL verification if we can't override the Host header. |
2e48165 to
eb38019
Compare
mboersma
added a commit
that referenced
this pull request
Dec 14, 2015
fix(k8s.py): access API server by IP address
oliverisaac
pushed a commit
to myriadmobile/deis-controller
that referenced
this pull request
Mar 27, 2019
fix(charts): set rbac apiVersion without casting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing the k8s api by hostname fails sometimes from within the deis/workflow pod. This changes the
requests.Sessionto use the IP address and port, which is more reliable, but at least for now requires disabling verification of the local SSL cert.Cert verification is
Falsehere since the IP address in the request does match any of the hostnames in the server's cert, and neither that verification nor the HTTPHostheader can be overridden in this case in the python requests library. That is, I couldn't see any way short of monkeypatching, after reading the requests source code and overriding several classes involved.