feat(client): use unix pipes with config:push#72
Conversation
client/parser/config.go
Outdated
There was a problem hiding this comment.
There isn't any technical reason we can't. I figured it would be confusing to offer two ways to do the same thing, but I don't have any strong feelings either way.
There was a problem hiding this comment.
IMO we should support both, but doesn't have to be blocking for this PR
|
@Joshua-Anderson We're getting close to freezing an Alpha of Deis v2. In your opinion, is this a risky one for us to try to merge at the last minute? Or should we wait until after Alpha. |
282a11b to
bcaba80
Compare
|
@technosophos Works on my machine (Ubuntu 15.10) ™️ 😃 I think merging this more of a decision if this change is desirable (some people may prefer flags over pipes). It's a small scoped and pretty easily testable change, so it wouldn't be too much work to land ( I have no idea how soon you want to release or how busy you are 😃) If this doesn't make it into the alpha, can backwards compatible changes still land in V2 before the GA release? This change also needs a complimentary change to |
bcaba80 to
28140d5
Compare
|
@Joshua-Anderson I think it's wise to implement |
Ok. Sounds good! I'm super busy right now, but if I have some time I'll fix it up. |
c4a440b to
9662783
Compare
|
@arschles I updated this PR to support both pipes and command line arguments. |
|
@Joshua-Anderson cool. My |
9662783 to
00a20c3
Compare
|
😦 As a side effect of enabling required status (which I am totally 👍 on), every time there is a commit on master, PRs are required to update before merging (to prevent accidental test breakage), which is a little annoying. |
feat(client): use unix pipes with config:push
|
hmm, that might be why everything needs to be rebased all the time. deis/deis does not have that enabled so that might be the bug. Definitely annoying :) |
This was briefly discussed as a V2 thing in deis/deis#4675 and deis/deis#4697.
I personally like it cause it's more unixy, but I understand if this is rejected because this is really a personal preference thing 😃.
If there is interest I will make the same change for
config:pull.