chore(models): move from django-json-field to jsonfield for Django 1.9 compatibility #179
Conversation
03610b7 to
b62b0c1
Compare
|
Wherein the pythongs ( 🐍 ) create unreadable migrations. |
|
whaaaaaaaaa! it's just an up and a down and the whole schema defintion all in one ... oh yeah, unreadable 😢 |
|
what's the reason for this migration? Is Django JSON Field incompatible with Django v1.9 or something? Shouldn't we just contribute fixes upstream for 1.9 compatibility instead? |
|
Yeah, it's incompatible - This seemed quicker as it provides the same functionality. The migrations are just so Django knows how to reference class it's hooked up to https://www.djangopackages.com/grids/g/json-fields/ going by this as well the one we currently are using hasn't been touched since 2014 and is not Python 3 compatible. derek-schaefer/django-json-field#42 is the reason for the 1.9 compatibility problem. There is a PR, no dice tho. |
|
Do we want this in alpha1? |
|
I feel it is as much of a risk as any other PR around. It can wait until Beta if people want to but I find it to be low risk unless we don't trust our tests (which have not always been able to catch pretty basic things, mind you) |
|
I'll leave it to @helgi @bacongobbler and @slack to decide whether we want to merge this today. |
|
I'd rather leave this out since it's not a showstopper for alpha, but I would like to get this one in as soon as we're done with the release. |
|
@helgi this ready to rumble? |
|
This one is ready, just needs another LGTM |
There was a problem hiding this comment.
for my knowledge, is this auto generated, and if so, by what?
There was a problem hiding this comment.
cd rootfs && ./manage.py makemigrations api --auto - this one is South that handles migrations
chore(models): move from django-json-field to jsonfield for Django 1.9 compatibility
Does not change any functionality and helps with other PRs