feat: improve statistics page on mobile devices #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the side-bar timeline dynamically shrinks to a smaller amount, while also keeping consistency with the top navigation bar between the map view and statistics page.
Contributor
|
Hi @sieren, thank you for the pr. We can put this in for the time. I think the final solution should be to also put the navigation under the main menu bar like it is done for the settings page. Would also have the benefit that it would fix the same problem for the memories page. There is no release planned until i have replaced leaflet with a more sophisticated map renderer. I can't promise you that this will be included or if i find the time to apply the settingsome navigation. |
Contributor
Author
|
Hey @dgraf-gh , that’s a great idea. I might look into that in due time. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
sorry for just opening a PR out of nowhere. I know reitti isn't a mobile-first project, nevertheless I was wondering if it's worth merging a small tweak that improves the situation on mobile by make sure the side-bar timeline for the statistics page dynamically shrinks to a smaller amount, while also keeping consistency with the top navigation bar between the map view and statistics page.