603 feature request location ingestion via mqtt #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Mosquitto MQTT container for testing purposes
- Introduced `DynamicMqttProvider` service to handle dynamic MQTT connections - Added `MqttIntegration` and `PayloadType` to configure client settings - Implemented `MqttPayloadProcessor` interface for payload processing - Integrated HiveMQ MQTT client dependencies
- Added `UserJdbcService` for managing users in MQTT configuration - Updated `DynamicMqttProvider` to support user-specific connections - Implemented `testConnection` method for verifying MQTT connectivity - Improved client connection handling and introduced QoS settings - Added `MqttIntegrationJdbcService` for database interactions - Created OwnTracks payload processor for handling location data - Added database migration script for `mqtt_integrations` table
…ository pattern with: 1. A method to find an MQTT integration by user 2. A save method that handles both create and update scenarios 3. Separate create and update methods 4. A row mapper to convert database rows to domain objects 5. Optimistic locking using a version field The code handles nullable timestamps, uses prepared statements for safe parameter insertion, and follows the existing code style. Would you like me to elaborate on any part of the implementation?
- Added `createdAt`, `updatedAt`, `lastUsed`, and `version` fields to `MqttIntegration` - Updated database operations to handle new fields - Replaced manual test user creation with `TestingService.randomUser` in tests - Fixed incorrect RabbitMQ container import in `TestContainerConfiguration`
…ient ID generation
…grations - Deleted `MqttIntegrationSettingsController` in favor of consolidating logic in `IntegrationsSettingsController` - Added support for saving and testing MQTT integrations in `IntegrationsSettingsController` - Refactored `MqttIntegration` with builder-like methods for easier updates - Simplified redirection and flash messaging for better user feedback - Improved CSS styling for read-only input elements
…troller - Updated `IntegrationsSettingsController` to use consistent parameter names prefixed with `mqtt_` - Adjusted HTML form inputs in `integrations.html` to align with updated parameter naming - Replaced `autocomplete="off"` with `autocomplete="new-password"` for better security practices
- Added detailed logging for MQTT client connection, subscription, and errors in `DynamicMqttProvider` - Refactored `remove` method to use `User` object instead of `userId` - Updated `IntegrationsSettingsController` to dynamically register or remove MQTT clients based on integration status
- Updated log level from `debug` to `info` in `DynamicMqttProvider` for client connection messages
- Log username when disconnecting MQTT client in `DynamicMqttProvider`
- Add `OwnTracksProcessor` to handle and process location messages - Integrate `LocationBatchingService` to queue validated location points - Add JSON parsing and validation for OwnTracks payloads - Improve MQTT disconnection log message in `DynamicMqttProvider`
…tor and method calls
…ngestion - Add `DynamicMqttProviderIntegrationTest` for comprehensive MQTT location processing validation - Add `mosquitto-no-auth.conf` configuration for Mosquitto MQTT test container - Enhance `DynamicMqttProvider` with `MqttStatus` enum for connection state tracking - Update test container to load Mosquitto configuration file
|
Does this also support MQTT over TLS (usually on port 8883)? I run my MQTT broker publicly and only allow encrypted TLS connections. |
Contributor
Author
I assume that the used library supports this out of the box. But I will test this before dping the release. |
I think there needs to be a specific "use TLS" setting which is passed to the library, I don't think there is any "magic" which automatically chooses TLS. |
Contributor
Author
|
Thanks for testing it. Let me add it |
Contributor
Author
|
MQTT connection test successful 🥳 Thanks! Will do some more tests in the coming days. |
|
Just for the record: I used MQTT ingestion the past few days, and I can report that it works perfectly well! |
Contributor
Author
Thank you for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.