Merged
Conversation
hensldm
approved these changes
Sep 10, 2023
Contributor
There was a problem hiding this comment.
LGTM. Tested on OoT and MM for regression. Did not test the new feature.
| return wrapper_fprintf(mem, STDOUT_ADDR, format_addr, sp); | ||
| uint32_t fp_addr = STDOUT_ADDR; | ||
|
|
||
| sp += 4; |
Contributor
There was a problem hiding this comment.
Interesting, was nothing using printf?
Contributor
Author
There was a problem hiding this comment.
tbh, I'm not completely sure, I made this PR months ago and this bit surprised me too 😅
I dug a bit in the discord and found this claim from my past self: https://discord.com/channels/710646040331681844/1018032155877724210/1109653246622060624
so, according to me, printf was almost completely unused, which makes sense considering the old implementation of printf and fprintf, where printf had very few cases implemented while fprintf was the chonky one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
c++filt5.3 to the recomped files.c++filtcan demangle IDO C++ mangling scheme.Other IDO 5.3 C++ files were added to the repo, but they are not being recomped since I didn't test them to work properly.
Also fixed
ctypeto beunsigned charinstead ofsigned chararray, andwrapper_printfskipping the first variadic argument.