Merged
Conversation
hensldm
reviewed
Sep 10, 2023
Contributor
There was a problem hiding this comment.
LGTM except the one small nit (which was my fault sorry again :( ). Regression tested on OoT and MM. Did not test C++ stuff though.
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
edgcpfe(the IDO C++ front end). For some reason theccdriver doesn't work properly when building a.cpp, but works fine if it is namedNCC(or variants), so I'm symlinking it during the build process.I had to adapt some stuff because
edgcpfeand family lives under the/usr/lib/DCCpath. I extended the path redirection to accept theDCC, same for the Makefile paths.Another problem for supporting 7.1
edgcpfewas the elf was linked against a 5.3libc.sofile, so it expects 5.3 libc addresses. Because of this I changed the makefile to build alibc_impl_53.ofile and use that when linking the recompededgcpfe.wrapper_getoptgave me a lot of problems when implementing it, but I believe it is properly implemented now.In the recomp side,
edgcpferequired two hacks for working properly because recomp couldn't determine the size of two jumptables.