msodde: Fix detecting DDE in the nested field.#807
Open
kijeong wants to merge 1 commit intodecalage2:masterfrom
Open
msodde: Fix detecting DDE in the nested field.#807kijeong wants to merge 1 commit intodecalage2:masterfrom
kijeong wants to merge 1 commit intodecalage2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I checked DDE in some malware .doc samples and found a malware doc that contained DDE but was not detected by the msodde.
I did a little research and It was because it nested.
It means, A field can contain another.
So I fixed that when DDE is detected, it collects characters in the buffer until it meets the END symbol, even if there's another BEGIN symbol in the middle.
I made a sample like this with the MS Office 365 Word.
(version: Microsoft® Word Microsoft 365 MSO(Version 2301 Build 16.0.16026.20196) 64bit, Korean)
ref:
Field = <Begin> *<Field> [Sep] *<Field> <End>thanks