Pass start dir to moduleconfig #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanMH
approved these changes
Aug 14, 2023
| message:"error %s", | ||
| args:["myParameter"] | ||
| it('will format the message with one argument and an internal parameter', function () { | ||
| const internalData = { test: true, myArray: [1, 2, 3] }; |
Comment on lines
-55
to
+57
| module.exports = getNodeErrors(); | ||
| module.exports = getNodeErrors; |
m-kusnierz
commented
Aug 14, 2023
package.json
Outdated
| "moduleconfig": "^2.0.0", | ||
| "underscore": "^1.8.3", | ||
| "uuid": "^3.0.1" | ||
| "@debitoor/moduleconfig": "github:debitoor/moduleconfig#pass-start-dir-to-function", |
Author
There was a problem hiding this comment.
This will be updated to specific version after releasing debitoor/moduleconfig#2
hilleer
reviewed
Aug 14, 2023
| "author": "Allan Ebdrup", | ||
| "name": "nodeerrors", | ||
| "author": "Debitoor", | ||
| "name": "@debitoor/nodeerrors", |
There was a problem hiding this comment.
I would not do this - it will make you publish an all new package under this scope. In such case, you should use version 1 as the previous versions will not exist for @debitoor/nodeerrors - I'd recommend to keep it as is.
Author
There was a problem hiding this comment.
nodeerrors in npm registry is not owned by us, so I guess we won't be able to publish it with this name.
@debitoor/nodeerrors with version 1 sounds better then?
There was a problem hiding this comment.
@bifrost is a collaborator on https://www.npmjs.com/package/nodeerrors - you can ask him to add you 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported function in lib/nodeerrors.js instead of exporting value returned by the function.
I also had to modify moduleconfig package so it takes a directory it should check for config, because it was also being cached by opentelemetry package (so it was always looking for the config in the same directory).
Depends on debitoor/moduleconfig#2