8000 Support for Symfony ^3.0 by athlan · Pull Request #7 · davedevelopment/pimple-aware-event-dispatcher · GitHub
[go: up one dir, main page]

Skip to content

Support for Symfony ^3.0 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Conversation

athlan
Copy link
Contributor
@athlan athlan commented Feb 24, 2018
  • Update composer dependencies
  • Make PimpleAwareEventDispatcher compatible with Symfony 2.8+ interface (details).

@@ -9,7 +9,7 @@
],
"require": {
"pimple/pimple": "3.*",
"symfony/event-dispatcher": "~2.1"
"symfony/event-dispatcher": "~2.1|^3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davedevelopment we could also change to: ~2.8|^3.0. What you think?

@athlan
Copy link
Contributor Author
athlan commented Mar 1, 2018

@davedevelopment any chance for merge?

@davedevelopment davedevelopment merged commit d8c56eb into davedevelopment:master Mar 2, 2018
@davedevelopment
Copy link
Owner

@athlan sorry for the delay. I've not had chance to test fully, so merging blind 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0