perf: sort microoptimize
#2748
Merged
perf: sort microoptimize
#2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- qualify how we randomize data (by row)
- micro-optimize writing sorted data, by pulling flag_unique check outside hot write loop (though IO-bound, no sense repeatedly checking flag_unique inside loop
- inline always compare_float which is a one-liner
- qualify how we randomize data (by row) - micro-optimize writing sorted data, by pulling flag_unique check outside hot write loop (though IO-bound, no sense repeatedly checking flag_unique inside loop - inline always compare_float which is a one-liner
There was a problem hiding this comment.
Pull Request Overview
This PR micro-optimizes the sort command by refining documentation, reducing branch checks in the hot loop, and inlining a one-liner comparison function.
- Clarified the
--randomflag description. - Pulled the
flag_uniquecheck outside the record-writing loop. - Added
#[inline(always)]tocompare_floatand silenced Clippy’s warning.
| @@ -42,7 +42,7 @@ sort options: | |||
| When not set, the number of jobs is set to the | |||
| number of CPUs detected. | |||
| --faster When set, the sort will be faster. This is done by | |||
| using a faster sorting algorithm that is not stable | |||
| using a faster sorting algorithm that is not "stable" | |||
There was a problem hiding this comment.
[nitpick] Wrapping stable in quotes may be confusing; use backticks (stable) to reference the stability guarantee or remove the quotes entirely for consistency with other option descriptions.
Suggested change
| using a faster sorting algorithm that is not "stable" | |
| using a faster sorting algorithm that is not `stable` |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.