Fix bitrot in Github Actions on older Python versions #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e30039 to
7c1b331
Compare
This fixes three issues blocking the Github Actions CI. 1. macos-latest now refers to an arm runner, which doesn't support some older verisons of Python. These need to be pinned. 2. pip on Python 3.5 now throws SSL errors as part of the setup-python action, and so we need to whitelist the PyPI hosts. We are not too concerned with MITM in this situation so this is probably fine. 3. The Codecov upload job is kind of flaky, so we will no longer fail CI if it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsurprisingly, the CI has started to bitrot again.
Looks like the current issues are actions/setup-python#866 and
macos-latestbeing an arm runner that does not have support for some older versions of Python.Codecov was also giving some errors due to rate limiting, so I've made it a soft check, since I am hoping to switch to a native GHA solution anyway.