fix: improve error handling when make_fetch referential integrity fails
#1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the _populate1 method in datajoint/autopopulate.py to treat referential integrity failures as critical errors by raising a DataJointError instead of silently rolling back and logging a warning.
- Removed transaction cancellation and warning on make_fetch data mismatch
- Added a
DataJointErrorto fail fast on referential integrity issues
Comments suppressed due to low confidence (1)
datajoint/autopopulate.py:415
- Add a unit test to verify that
_populate1raisesDataJointErrorwhen themake_fetchdata changes, ensuring this new error path is exercised.
): # raise error if fetched data has changed
dimitri-yatsenko
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the behavior of the
_populate1method indatajoint/autopopulate.pyto improve error handling for referential integrity issues.Error handling changes:
_populate1method to raise aDataJointErrorwhen fetched data changes, replacing the previous behavior of canceling the transaction and logging a warning. This ensures that referential integrity issues are treated as critical errors and handled explicitly.