8000 fix(ingest/snowflake): fix type annotations + refactor get_connect_args by hsheth2 · Pull Request #7004 · datahub-project/datahub · GitHub
[go: up one dir, main page]
Skip to content

fix(ingest/snowflake): fix type annotations + refactor get_connect_args #7004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix(ingest/snowflake): fix type annotations + refactor get_connect_args #7004

merged 1 commit into from
Jan 11, 2023

Conversation

hsheth2
Copy link
Collaborator
@hsheth2 hsheth2 commented Jan 11, 2023 •
edited
Loading

In the latest releast of types-PyOpenSSL, they removed their dep on types-cryptography (python/typeshed#9459). This caused mypy to start using the type annotations provided by the cryptography package, which caused an issue in our build. Example build failure: https://github.com/datahub-project/datahub/actions/runs/3888835554/jobs/6636552750

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(ingest/snowflake): fix type annotations + refactor get_connect_args
c3b3302 
In the latest releast of types-PyOpenSSL, they removed their dep on
types-cryptography (python/typeshed#9459). This
caused mypy to start using the type annotations provided by the
cryptography package, which caused an issue in our build. Example build
failure: https://github.com/datahub-project/datahub/actions/runs/3888835554/jobs/6636552750
@hsheth2 hsheth2 requested a review from treff7es January 11, 2023 02:44
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 11, 2023
treff7es
treff7es previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor
@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es enabled auto-merge (squash) January 11, 2023 02:45
@treff7es treff7es merged commit 93dd87a into datahub-project:master Jan 11, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Jan 18, 2023
@hsheth2
fix(ingest/snowflake): fix type annotations + refactor get_connect_ar…
41a4f5d 
…gs (datahub-project#7004)
@hsheth2 hsheth2 deleted the snowflake-type-fix branch February 14, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es
0