8000 Use a column to store categories, rather than a mapping by shwina · Pull Request #69 · data-apis/dataframe-api · GitHub
[go: up one dir, main page]
Skip to content

Use a column to store categories, rather than a mapping #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Use a column to store categories, rather than a mapping #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b42205
Use a column to store categories
shwina Sep 29, 2021
902ba7c
Make .describe_categoricals["mapping"] a Column
vnlitvinov Jun 1, 2022
b0b2526
Rename "mapping" -> "categories" in .describe_categorical
vnlitvinov Jul 7, 2022
3869827
Update protocol/dataframe_protocol.py
vnlitvinov Jul 7, 2022
7f0cdfb
Merge branch 'main' into store-categories-in-column
rgommers Jul 28, 2022
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into store-categories-in-column
  • Loading branch information
@rgommers
rgommers committed Jul 28, 2022
commit 7f0cdfb231d3beb766b664127bc91ab726e04567
4 changes: 2 additions & 2 deletions protocol/design_requirements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ or dataframe that contains a set of (neighboring) rows.

8. Must support missing values (`NA`) for all supported dtypes.

9. Must supports string, categorical and datetime dtypes.
9. Must support string, categorical and datetime dtypes.

10. Must allow the consumer to inspect the representation for missing values
that the producer uses for each column or data type. Sentinel values,
Expand Down Expand Up @@ -118,7 +118,7 @@ We'll also list some things that were discussed but are not requirements:
interleaved array in NumPy._

3. Extension dtypes, i.e. a way to extend the set of dtypes that is
explicitly support, are out of scope.
explicitly supported, are out of scope.

_Rationale: complex to support, not used enough to justify that complexity._

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
0