TST: fix cupy to_device test on multiple devices
#326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the cupy to_device test so that it runs correctly on multiple devices. The key changes include replacing direct stream instantiation with lambda functions to lazily create stream objects within the device context and updating the loop variable name to reflect its callable nature.
Comments suppressed due to low confidence (1)
tests/test_cupy.py:20
- [nitpick] Consider renaming 'stream_gen' to 'stream_factory' to better reflect its purpose as a callable that returns a new stream instance.
for stream_gen in streams:
Member
|
Thanks. I'll retest it later today. |
Member
|
Actually, gave it a spin now: |
Contributor
Author
|
@ev-br please try now |
Member
|
Contributor
Author
|
looks good to me. Outstanding error is fixed by #325. |
Contributor
Author
|
Test failure is unrelated |
Member
|
Merged, thanks. |
Contributor
Author
No. As per both the CuPy and the Array API spec, it needs to be a stream pointer, whatever that means on the backend. On CUDA, that means it must have been returned by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
to_devicetest for cupy when there are multiple devices.UNTESTED, as I don't have multiple GPUs to try this on.
Partially fixes #324.