Move from_binsparse to sparse submodule.

data-apis · hameerabbasi · Mar 10, 2025 · Apr 3, 2025 · Apr 3, 2025 · Apr 3, 2025
commit af51eb5e370ccc6f9b9c26890ec094d17a9a8a6b
diff --git a/spec/draft/extensions/sparse_interchange.rst b/spec/draft/extensions/sparse_interchange.rst
@@ -10,7 +10,7 @@ Extension name and usage
 
 If implemented, this extension must be retrievable via::
 
-    >>> if hasattr(x, '__dlpack__'):
+    >>> if hasattr(x, 'sparse'):
     >>>     # Use the extension
 
 Objects in API
@@ -28,7 +28,7 @@ functions/methods.
    :toctree: generated
    :template: method.rst
 
-   from_binsparse
+   sparse.from_binsparse
 
 
 .. autosummary::

diff --git a/src/array_api_stubs/_draft/__init__.py b/src/array_api_stubs/_draft/__init__.py
@@ -16,6 +16,7 @@
 from .utility_functions import *
 from . import linalg
 from . import fft
+from . import sparse
 from .info import __array_namespace_info__
 
 

diff --git a/src/array_api_stubs/_draft/creation_functions.py b/src/array_api_stubs/_draft/creation_functions.py
@@ -4,7 +4,6 @@
     "empty",
     "empty_like",
     "eye",
-    "from_binsparse",
     "from_dlpack",
     "full",
     "full_like",
@@ -646,26 +645,3 @@ def zeros_like(
     out: array
         an array having the same shape as ``x`` and filled with zeros.
     """
-
-
-def from_binsparse(arrays: dict[str, array], descriptor: dict, /) -> array:
-    """
-    Returns a new array containing the data from another (array) object with a ``__binsparse__`` method.
-
-    Parameters
-    ----------
-    arrays: dict[str, array]
-        input constituent arrays.
-    descriptor: dict
-        the parsed binsparse descriptor of the array.
-
-    Returns
-    -------
-    out: array
-        an array containing the data in `arrays` with a format specified by `descriptor`.
-
-        .. admonition:: Note
-           :class: note
-
-           The returned array may be either a copy or a view. See :ref:`data-interchange` for details.
-    """
diff --git a/src/array_api_stubs/_draft/sparse.py b/src/array_api_stubs/_draft/sparse.py
@@ -0,0 +1,28 @@
+from __future__ import annotations
+
+from ._types import array
+
+__all__ = ["from_binsparse"]
+
+
+def from_binsparse(arrays: dict[str, array], descriptor: dict, /) -> array:
+    """
+    Returns a new array containing the data from another (array) object with a ``__binsparse__`` method.
+
+    Parameters
+    ----------
+    arrays: dict[str, array]
+        input constituent arrays.
+    descriptor: dict
+        The parsed binsparse descriptor of the array.
+
+    Returns
+    -------
+    out: array
+        an array containing the data in `arrays` with a format specified by `descriptor`.
+
+        .. admonition:: Note
+           :class: note
+
+           The returned array may be either a copy or a view. See :ref:`data-interchange` for details.
+    """