-
Notifications
You must be signed in to change notification settings - Fork 52
fix: finfo_object
, iinfo_object
, _array
to typing.Protocol
#857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: fix docs again
- Loading branch information
commit f3c9eb4a45f413cd965e6c6a1711192dca2f92ba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,3 +35,5 @@ tmp/ | |
*.egg | ||
dist/ | ||
.DS_STORE | ||
venv | ||
.venv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
from ._types import Array | ||
|
||
# for documentation | ||
array = Array | ||
|
||
__all__ = ["array"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,24 @@ | ||
__all__ = ["__eq__"] | ||
from __future__ import annotations | ||
|
||
__all__ = ["DType"] | ||
|
||
from ._types import dtype | ||
|
||
from typing import Protocol | ||
|
||
def __eq__(self: dtype, other: dtype, /) -> bool: | ||
""" | ||
Computes the truth value of ``self == other`` in order to test for data type object equality. | ||
|
||
Parameters | ||
---------- | ||
self: dtype | ||
data type instance. May be any supported data type. | ||
other: dtype | ||
other data type instance. May be any supported data type. | ||
|
||
Returns | ||
------- | ||
out: bool | ||
a boolean indicating whether the data type objects are equal. | ||
""" | ||
class DType(Protocol): | ||
def __eq__(self, other: DType, /) -> bool: | ||
""" | ||
Computes the truth value of ``self == other`` in order to test for data type object equality. | ||
Parameters | ||
---------- | ||
self: dtype | ||
data type instance. May be any supported data type. | ||
other: dtype | ||
other data type instance. May be any supported data type. | ||
Returns | ||
------- | ||
out: bool | ||
a boolean indicating whether the data type objects are equal. | ||
""" | ||
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what the
[device]
here means after Protocol? The Info namespace object itself does not depend on the device (__array_namespace_info__
does not take adevice
parameter).