8000 Update DLPack content to address unsupported use cases by rgommers · Pull Request #709 · data-apis/array-api · GitHub
[go: up one dir, main page]
Skip to content

Update DLPack content to address unsupported use cases #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2024
Merged

Update DLPack content to address unsupported use cases #709

merged 2 commits into from
Jan 12, 2024

Conversation

rgommers
Copy link
Member

No description provided.

@rgommers rgommers requested a review from leofang November 16, 2023 21:27
leofang
leofang approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor
@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ralf! LGTM except for one nit.

@leofang leofang added this to the v2023 milestone Nov 16, 2023
@leofang
Copy link
Contributor
leofang commented Nov 16, 2023

Q: Does it matter that we backport this?

@rgommers
Copy link
Member Author

Q: Does it matter that we backport this?

Not sure, perhaps not. I wouldn't exactly consider it a bug fix.

seberg
seberg reviewed Nov 17, 2023
View reviewed changes
@rgommers
Copy link
Member Author

It looks like we're happy as is with this PR, right? I'll plan to merge it soon unless there's an objection.

@leofang
Copy link
Contributor
leofang commented Jan 12, 2024

Yup ready to go anytime!

@seberg
Copy link
Contributor
seberg commented Jan 12, 2024

Yes, thank you!

@rgommers rgommers merged commit 7a56675 into data-apis:main Jan 12, 2024
@rgommers rgommers deleted the update-dlpack-supported branch January 12, 2024 09:41
@Micky774 Micky774 mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg left review comments

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.
3 participants
@rgommers @leofang @seberg
0