Add device keyword to fftfreq and rfftfreq
#506
Conversation
|
Should we mention that only inexact data types, i.e. "real floating" and "complex floating" are expected to be supported? |
|
@oleksandr-pavlyk Updated the PR to require that |
|
This change matches the discussion. |
|
@rgommers I was thinking the same thing. The |
|
As discussed in our previous meeting, we are not going to add |
|
Found a previous issue on the NumPy issue tracker (numpy/numpy#9126) raised by @jakirkham concerning supporting a |
dtype and device to fftfreq and rfftfreqdtype and~ device to fftfreq and rfftfreq
dtype and~ device to fftfreq and rfftfreqdevice keyword to fftfreq and rfftfreq
There was a problem hiding this comment.
LGTM, this addresses gh-500 by adding the needed device keyword.
The dtype discussion seems to be of theoretical interest, but - given that no library actually implement it - of very limited practical value. Let's punt on that; if anyone actually needs it, let them implement it at least in numpy first.
This PR,
deviceas arguments tofftfreqdeviceas arguments torfftfreqThis PR fixes #500