Update the specification for remainder to include special cases for floating-point operands
#401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honno
reviewed
Mar 10, 2022
honno
reviewed
Mar 10, 2022
Co-authored-by: Matthew Barber <quitesimplymatt@gmail.com>
Co-authored-by: Matthew Barber <quitesimplymatt@gmail.com>
Co-authored-by: Matthew Barber <quitesimplymatt@gmail.com>
Co-authored-by: Matthew Barber <quitesimplymatt@gmail.com>
honno
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
LGTM.
Also, ran these special cases through the test suite (specifically data-apis/array-api-tests#104)—they're all machine-readable, and pass for numpy.array_api.
|
Awesome! Thanks, @honno! |
|
As this has been open for review for over 10 days and has been approved, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
remainder(and, by extension, the__mod__method) to include special cases for floating-point operands.%operator.remainderfor floating-point operands, given that behavior does not follow IEEE 754 (i.e., results can deviate fromr = x - n*floor(x/y), particularly during overflow and underflow). As floating-point operand acceptance is common across all implementing array libraries, the specification permits their support for reasons of backward compatibility.remainder()should have special cases #385.