8000 Add support for building on aarch64 on Linux by michael-sanders · Pull Request #771 · dask/fastparquet · GitHub
[go: up one dir, main page]
Skip to content

Add support for building on aarch64 on Linux #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 19, 2022
Merged

Add support for building on aarch64 on Linux #771

merged 9 commits into from
Apr 19, 2022

Conversation

michael-sanders
Copy link
@michael-sanders michael-sanders commented Apr 8, 2022 •
edited by martindurant
Loading

This adds in the appropriate option to build on aarch64 (ARM) on Linux in addition to builds generated by the 'auto' option. This is as per the docs at https://cibuildwheel.readthedocs.io/en/stable/options/#archs

Closes #770

@michael-sanders michael-sanders mentioned this pull request Apr 8, 2022
Closed
@martindurant
Copy link
Member

@michael-sanders , it seems that building all those wheels under QEMU is is just taking too long with this addition. Do you think we can split up the job, building some wheels in each, to get around this? As it stands, you can include "wheels" as the commit message to try the build.

@martindurant
Copy link
Member

built all manylinux, timed out building muslinux. Do we need both, can they be split?

@michael-sanders
Copy link
Author

built all manylinux, timed out building muslinux. Do we need both, can they be split?

Thanks @martindurant. I'll take a look.

@michael-sanders
Do not attempt to build musllinux on aarch64
fe96260 
numpy dependency does not yet supply musllinux wheels and they take too long to build on aarch64. Can be re-enabled when numpy wheels are available via numpy/numpy#20089
@michael-sanders
Copy link
Author

The numpy dependency does not yet supply musllinux wheels and so we have to build them. This takes too long on aarch64 and so musllinux wheels should be disabled for this platform (see fe96260). We can re-enable this when numpy has merged a fix for numpy/numpy#20089

@martindurant
Copy link
Member

aarch wheels are up.

@martindurant martindurant merged commit 0504f25 into dask:main Apr 19, 2022
@michael-sanders
Copy link
Author

Great, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fastparquet 0.8.1 Linux aarch64 builds are missing
2 participants
@michael-sanders @martindurant
0