8000 Explain intermediate storage by jakirkham · Pull Request #4025 · dask/dask · GitHub
[go: up one dir, main page]
Skip to content

Explain intermediate storage #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 1, 2019
Merged

Explain intermediate storage #4025

merged 10 commits into from
May 1, 2019

Conversation

jakirkham
Copy link
Member

Provide some prose to explain the use case of storing intermediate values using return_stored as well as some examples of these common use cases.

@jakirkham
DOC: Explain intermediate storage [ci skip]
e497481 
Provide some prose to explain the use case of storing intermediate
values using `return_stored` as well as some examples of these common
use cases.
mrocklin
mrocklin reviewed Oct 1, 2018
View reviewed changes
mrocklin
mrocklin reviewed Oct 1, 2018
View reviewed changes
mrocklin
mrocklin reviewed Oct 1, 2018
View reviewed changes
@mrocklin
Copy link
Member
mrocklin commented Oct 1, 2018

Thanks for writing this up. I've added a few comments with some concerns, but I'm confident that we can come to something that will be pretty useful for readers.

@martindurant
Copy link
Member

@jakirkham , sounds like this didn't need too much effort to push it in, were you thinking to work on it yet?

@jakirkham
Copy link
Member Author

Alright I've gone through this and more or less rewritten the text. IMHO it is much better, but please take a look and let me know if it captures what you were after. Have also moved the section.

@mrocklin
Copy link
Member

IMHO it is much better

:) Not sure that you can say that

@martindurant martindurant mentioned this pull request Apr 30, 2019
Closed
mrocklin
mrocklin reviewed Apr 30, 2019
View reviewed changes
Copy link
Member
@mrocklin mrocklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky comments. In general this looks great though!

@mrocklin mrocklin merged commit 0199be4 into dask:master May 1, 2019
@mrocklin
Copy link
Member
mrocklin commented May 1, 2019

Thanks @jakirkham . This looks good to me. Merging in.

@jakirkham
Copy link
Member Author

Thanks for the review Matt! Hopefully this helps some people 🙂

@jakirkham jakirkham deleted the doc_return_stored branch May 1, 2019 17:54
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019
@jakirkham
Explain intermediate storage for dask arrays (dask#4025)
6d83763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrocklin mrocklin mrocklin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @mrocklin @martindurant
0