danmar · firewave · Mar 22, 2025 · Jun 30, 2025 · Jul 4, 2025 · danmar
diff --git a/lib/token.cpp b/lib/token.cpp
@@ -2545,6 +2545,18 @@ bool Token::hasKnownSymbolicValue(const Token* tok) const
     });
 }
 
+const ValueFlow::Value* Token::getKnownValue() const
+{
+    if (!mImpl->mValues)
+        return nullptr;
+    if (mImpl->mValues->empty())
+        return nullptr;
+    auto it = std::find_if(mImpl->mValues->begin(), mImpl->mValues->end(), [&](const ValueFlow::Value& value) {
+        return value.isKnown();
+    });
+    return it == mImpl->mValues->end() ? nullptr : &*it;
+}
+
 const ValueFlow::Value* Token::getKnownValue(ValueFlow::Value::ValueType t) const
 {
     if (!mImpl->mValues)

diff --git a/lib/token.h b/lib/token.h
@@ -1321,6 +1321,7 @@ class CPPCHECKLIB Token {
     bool hasKnownValue(ValueFlow::Value::ValueType t) const;
     bool hasKnownSymbolicValue(const Token* tok) const;
 
+    const ValueFlow::Value* getKnownValue() const;
     const ValueFlow::Value* getKnownValue(ValueFlow::Value::ValueType t) const;
     MathLib::bigint getKnownIntValue() const {
         assert(!mImpl->mValues->empty());

diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -7017,10 +7017,12 @@ static void valueFlowDynamicBufferSize(const TokenList& tokenlist, const SymbolD
                 sizeValue = arg1->getKnownIntValue() * arg2->getKnownIntValue();
             break;
         case Library::AllocFunc::BufferSize::strdup:
-            if (arg1 && arg1->hasKnownValue()) {
-                const ValueFlow::Value& value = arg1->values().back();
-                if (value.isTokValue() && value.tokvalue->tokType() == Token::eString)
-                    sizeValue = Token::getStrLength(value.tokvalue) + 1; // Add one for the null terminator
+            if (arg1) {
+                if (const ValueFlow::Value* value = arg1->getKnownValue(ValueFlow::Value::ValueType::TOK))
+                {
+                    if (value->tokvalue->tokType() == Token::eString)
+                        sizeValue = Token::getStrLength(value->tokvalue) + 1; // Add one for the null terminator
+                }
             }
             break;
         }
@@ -7279,7 +7281,10 @@ const ValueFlow::Value *ValueFlow::valueFlowConstantFoldAST(Token *expr, const S
         valueFlowConstantFoldAST(expr->astOperand2(), settings);
         valueFlowSetConstantValue(expr, settings);
     }
-    return expr && expr->hasKnownValue() ? &expr->values().front() : nullptr;
+    const auto* v = expr && expr->hasKnownValue() ? &expr->values().front() : nullptr;
+    if (v)
+        assert(v->isKnown());
+    return v;
 }
 
 struct ValueFlowState {

diff --git a/lib/vf_settokenvalue.cpp b/lib/vf_settokenvalue.cpp
@@ -391,11 +391,10 @@ namespace ValueFlow
 
         else if (parent->str() == "?" && tok->str() == ":" && tok == parent->astOperand2() && parent->astOperand1()) {
             // is condition always true/false?
-            if (parent->astOperand1()->hasKnownValue()) {
-                const Value &condvalue = parent->astOperand1()->values().front();
-                const bool cond(condvalue.isTokValue() || (condvalue.isIntValue() && condvalue.intvalue != 0));
+            if (const Value* condvalue = parent->astOperand1()->getKnownValue()) {
+                const bool cond(condvalue->isTokValue() || (condvalue->isIntValue() && condvalue->intvalue != 0));
                 if (cond && !tok->astOperand1()) { // true condition, no second operator
-                    setTokenValue(parent, condvalue, settings);
+                    setTokenValue(parent, *condvalue, settings);
                 } else {
                     const Token *op = cond ? tok->astOperand1() : tok->astOperand2();
                     if (!op) // #7769 segmentation fault at setTokenValue()