8000 Update poetry to version 2 by jameshilliard · Pull Request #654 · danielgtaylor/python-betterproto · GitHub
[go: up one dir, main page]
Skip to content

Update poetry to version 2 #654

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2025
Merged

Update poetry to version 2 #654

merged 4 commits into from
Jan 14, 2025

Conversation

jameshilliard
Copy link
Contributor

Fix some issues flagged by poetry check.

@jameshilliard
Update poetry to version 2
3ba3a74 
Fix some issues flagged by poetry check.
abn
abn requested changes Jan 13, 2025
View reviewed changes
abn
abn reviewed Jan 13, 2025
View reviewed changes
jameshilliard and others added 2 commits January 14, 2025 02:04
@jameshilliard @abn
Limit poetry-core to less than version 3
6a6d603 
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@jameshilliard @abn
Limit python to <4.0
83f66e1 
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@abn
Copy link
Collaborator
abn commented Jan 14, 2025

The CI Is still installing Poetry 1.8.5.

https://github.com/danielgtaylor/python-betterproto/actions/runs/12758366227/job/35583665469#step:5:142

Might need to update that in a separate PR first.

@jameshilliard jameshilliard force-pushed the fix-poetry branch 6 times, most recently from ba6692d to 8b7d1c4 Compare January 14, 2025 12:46
@jameshilliard
Copy link
Contributor Author

I think I got tests all passing now, had to drop python 3.8 support(python 3.8 is deprecated).

@abn abn merged commit f33a42b into danielgtaylor:master Jan 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameshilliard @abn
0