8000 Bug fix in casing.sanitize_name for names starting with an int by Gobot1234 · Pull Request #192 · danielgtaylor/python-betterproto · GitHub
[go: up one dir, main page]
Skip to content

Bug fix in casing.sanitize_name for names starting with an int #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bug fix in casing.sanitize_name for names starting with an int #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26069db
Check if the first character is an int
Gobot1234 Dec 30, 2020
175b944
Blacken
Gobot1234 Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/betterproto/casing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,8 @@ def lowercase_first(value: str) -> str:

def sanitize_name(value: str) -> str:
# https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
return f"{value}_" if keyword.iskeyword(value) else value
if keyword.iskeyword(value):
return f"{value}_"
if value[0].isdigit():
return f"_{value}"
return value
0